mysql - php script for upload image not working -

-

i have edit page allow users upload profile image using forms problem keep getting the format not acceptable if image type 1 of accepted format.

this code

if(isset($_post['parse_var']) == "pic")     {         if(!$_files['filefield']['tmp_name'])         {             $errormsg = '<font color= "#ff0000">please browse image  before press button.</font>';         }         else         {             $maxfilesize = 51200;//in bytes =  50kb             if($_files['filefield']['size']>$maxfilesize)             {                 $errormsg = '<font color="#ff0000">your image large, please try again.</font>';                 unlink($_files['filefield']['tmp_name']);             }             elseif(!preg_match("^.(gif|jpg|png)$/i^",$_files['filefield']['name']))             {                 $errormsg = '<font color="#ff0000">your image not 1 of accepted format, please try again</font>';                 unlink($_files['filefield']['tmp_name']);             }             else             {                 $newname = "image01.jpg";                 $place_file = move_uploaded_file($_files['filefield']['tmp_name'],"members/$id/".$newname);                 $message='<font color="#00ff00>your image has been upload successfully</font>';             }         }//end else      }//end if

major problems:

a)

        elseif(!preg_match("^.(gif|jpg|png)$/i^",$_files['filefield']['name']))                             ^---

you should not using regex metachar pattern delimiter. try

preg_match('/\.(gif|jpg|png)$/i', ...) instead.

but in bigger picture view, shouldn't matching on filenames @ all. filenames can forged. should doing server-side mime-type determination (e.g. via file_info()) instead.

b)

you not checking upload success. presence of ['tmp_name'] in $_files array means nothing. failed uploads can still produce tmp_name, yet end garbage. use this:

if ($_files['filefield']['error'] !== upload_err_ok) {    die("upload failed error code " . $_files['filefield']['error']); }

the error codes defined here: http://php.net/manual/en/features.file-upload.errors.php

c) (minor)

you no need unlink temp files. php automatically when script exits.

d) (stylistically huge error)

font tags? in 2013? 1990s called , want html 1.0 back...


Comments

Post a Comment

Popular posts from this blog

java - Jmockit String final length method mocking Issue -

-
using jmockit 1.2 jar, trying mock string's length method getting unexpected invocation exception: failed: test java.lang.illegalstateexception: missing invocation mocked type @ point; please make sure such invocations appear after declaration of suitable mock field or parameter @ stringdemo.testa$1.<init>(testa.java:17) @ stringdemo.testa.test(testa.java:13) i using testng: @test public void test() throws exception { new expectations() { @mocked("length") string astring; { astring.length(); result = 2; } }; system.out.println(a.showa("test")); } } actual class a: public class { public static int showa(string str){ int a= str.length(); return a; } } this wrong way of recording expected results. shouldn't mock , record string's length() method, record showa() instead. here solution @suppresswarnings("unused&qu
Read more

asp.net - Razor Page Hosted on IIS 6 Fails Every Morning -

-
i have simple page in intranet uses razor/asp fetch single record table , display it, plus few graphic, dashboard display. meaning, no user intervention other first time open ie internal url. the problem having every morning ie displays "page not found or network error" message. refresh page, , it's stuck , doesn't display anything. try different pc, open ie internal url , it's stuck... ...until following: login server hosting page run inetmgr go web sites, etc right click on page that's giving me problem , select browse at moment, error message: server error in '/' application. -------------------------------------------------------------------------------- type of page not served. description: type of page have requested not served because has been explicitly forbidden. extension '.cshtml' may incorrect. please review url below , make sure spelled correctly. requested url: /application/dashboard.cshtml ---------------
Read more

c++ - wxwidget compiling on windows command prompt -

-
can please guide me on method,as how compile wxwidget using windows command prompt or msys. [i can't seem find on wxwiki/wxwidget official book/anywhere else] i have compiled wxwidget instructions have provided (using msys). from searching on internet seems 1 can (maybe?) through use of makefile (is correct?) if yes: directory & how should link wx libraries in makefile if no: way besides makefile? i know can use ide's code::block , make life simpler prefer compile using command prompt/msys. thanks in advance.
Read more